Error out early when work dir does not exists and is expected to. #171
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auxilliary commands such as pgcopydb list progress expect the work directory to have been created already. Check that early in the code.
Then fix the callers and make most of them re-use a pre-existing directory rather than create a default one and then use it.
arajkumar
added a commit
to arajkumar/pgcopydb
that referenced
this pull request
Dec 10, 2024
60312a2 Fix double free on pipeline sync failure (dimitri#170) 88e0416 Fix invalid UPDATE stmt when none of the columns change (dimitri#169) 2196dcc Add validation failure message into telemetry (dimitri#168) Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auxilliary commands such as pgcopydb list progress expect the work directory to have been created already. Check that early in the code.