Refactor our internal representation for Logical Messages. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The KEEPALIVE and SWITCH WAL messages could be part of a transaction (typically one that spans multiple WAL files), but also can be found independently, between transactions. Our previous internal representation insisted that every message be put in the context of a transaction, but that doesn't fit well with the reality. This refactoring is also necessary for streaming, where we don't want to wait until the end of the next transaction before replaying the KEEPALIVE messages. That kind of defeat the purpose of a KEEPALIVE message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KEEPALIVE and SWITCH WAL messages could be part of a transaction (typically one that spans multiple WAL files), but also can be found independently, between transactions.
Our previous internal representation insisted that every message be put in the context of a transaction, but that doesn't fit well with the reality.
This refactoring is also necessary for streaming, where we don't want to wait until the end of the next transaction before replaying the KEEPALIVE messages. That kind of defeat the purpose of a KEEPALIVE message.