Fix internal return value that prevented error handling. #204
8000Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of early exit without retries from function copydb_copy_table we would break out of the retry loop and return true, allowing pgcopydb to continue working and report a successful return code to the OS. In passing, also review error handling in lower-level pg_copy function to prevent trying to COMMIT a transaction in an already failed connection. Finally, we 85A5 could have either a client-side connection error or a server-side reported connection error: improve our code to take both the situations into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of early exit without retries from function copydb_copy_table we would break out of the retry loop and return true, allowing pgcopydb to continue working and report a successful return code to the OS.
In passing, also review error handling in lower-level pg_copy function to prevent trying to COMMIT a transaction in an already failed connection.
Finally, we could have either a client-side connection error or a server-side reported connection error: improve our code to take both the situations into account.
Should fix #201.