Create new process group for pgcopydb initialization. #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri
reviewed
Mar 17, 2023
src/bin/pgcopydb/main.c
Outdated
Comment on lines
46
to
47
| /* create a new process group and set current process as its leader. This | ||
| * allows the process group to be easily controlled, without affecting any |
There was a problem hiding this comment.
Nitpicking: please conform to the comment style used in the rest of the project. It would then look like this:
/*
* Create a new process group...
* 0dbbd2e to
f055201
Compare
Previously, when `pgcopydb` encountered a FATAL error and called `copydb_fatal_exit`, any wrapper processes around `pgcopydb` would also get terminated due to the `if (kill(0, SIGTERM) == -1)` statement. To fix this issue, a new process group is now created for `pgcopydb` during initialization. This ensures that only the `pgcopydb` process will be terminated in case of a FATAL error, leaving the wrapper processes intact.
f055201 to
a8146e8
Compare
dimitri
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
pgcopydbencountered a FATAL error and calledcopydb_fatal_exit, any wrapper processes aroundpgcopydbwould also get terminated due to theif (kill(0, SIGTERM) == -1)statement. To fix this issue, a new process group is now created forpgcopydbduring initialization. This ensures that only thepgcopydbprocess will be terminated in case of a FATAL error, leaving the wrapper processes intact.