Fix when we VACUUM ANALYZE. #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Careful reading of the Explicit Locking chapter of Postgres documentation shows that VACUUM and ANALYZE take a SHARE UPDATE EXCLUSIVE lock against the target table, and CREATE INDEX take a SHARE lock, which conflicts with the former one. https://www.postgresql.org/docs/current/explicit-locking.html So we can't actually VACUUM ANALYZE a table while building the indexes and then constraints on top of that. The queueing of the VACUUM operations is now done after the indexes and constraints are built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Careful reading of the Explicit Locking chapter of Postgres documentation shows that VACUUM and ANALYZE take a SHARE UPDATE EXCLUSIVE lock against the target table, and CREATE INDEX take a SHARE lock, which conflicts with the former one.
https://www.postgresql.org/docs/current/explicit-locking.html
So we can't actually VACUUM ANALYZE a table while building the indexes and then constraints on top of that. The queueing of the VACUUM operations is now done after the indexes and constraints are built.