Fix double precision out of range during COPY. #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have identified the root cause of the issue where double precision values were going out of range during the COPY operation. It turns out that we were missing the extra_float_digits GUC (grand unified configuration) while copying the float8 data. As a result, when extreme values like '1.7976931348623157E+308' were copied from the source, an overflow occurred leading to the following error: ```log 2023-05-08 14:17:00 16666 ERROR pgsql.c:2555 TARGET [22003] ERROR: "1.79769313486232e+308" is out of range for type double precision 2023-05-08 14:17:00 16666 ERROR pgsql.c:2559 TARGET CONTEXT: COPY t_numeric_types, line 46650, column c_double_precision: "1.79769313486232e+308" 2023-05-08 14:17:00 16666 ERROR pgsql.c:2563 TARGET Context: Failed to copy data to target ```
ecc1d3d to
9466b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified the root cause of the issue where double precision values were going out of range during the COPY operation. It turns out that we were missing the extra_float_digits GUC (grand unified configuration) while copying the float8 data. As a result, when extreme values like '1.7976931348623157E+308' were copied from the source, an overflow occurred leading to the following error:
Value of
3is inspired frompg_dumphttps://github.com/postgres/postgres/blob/ff4213cdc2e2bef7fadba6db2fc97057fd03be74/src/bin/pg_dump/pg_dump.c#L1176