Fix apply when file starts with non-begin/keepalive statements. #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issues where we skip applying I/U/D/T/C leading to the warning "there is already a transaction in progress" when a txn continues to next file and first statement of that file is not a BEGIN or KEEPALIVE statement. In that case, `reachedStartPos` is never set to true and apply never starts. This happens because `reachedStartPos` is set to `false` everytime a new file is processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues where if a txn continues to next file and first statement of that file is not a BEGIN or KEEPALIVE statement then we skip applying COMMIT as well as I/U/T/D leading to the warning "there is already a transaction in progress".
This happens because
reachedStartPosis set tofalseeverytime a new file is processed. SincereachedStartPosis never set to true and apply doesn't starts untilBEGINorKEEPALIVEis found.