Fix transforming UPDATE messages WHERE/SET clauses. #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logical decodi
8000
ng messages both from test_decoding and wal2json might
contain the same column in both WHERE and SET clauses with the same value.
When that's the case, it's best to reduce the UPDATE statement and refrain
from adding the same column-value pair in both clauses.
Also that's not just an optimisation now, as without this the following
could happen:
ERROR: column "id" can only be updated to DEFAULT
DETAIL: Column "id" is an identity column defined as GENERATED ALWAYS.
edf8633 to
35e6787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logical decoding messages both from test_decoding and wal2json might contain the same column in both WHERE and SET clauses with the same value. When that's the case, it's best to reduce the UPDATE statement and refrain from adding the same column-value pair in both clauses.
Also that's not just an optimisation now, as without this the following could happen:
Fixes #313