Skip importing snapshot we won't use, fix pgsql error handling. 8000 #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pgsql.c for the case when we fail to execute a SQL command without parameters, such as e.g. the very simple "COMMIT;" command. First, we might not be given a SQLSTATE, and second, we need to pay attention about that lack of debugParameters. Also improve `pgcopydb clone` command to avoid importing a snapshot in the top-level process. This process might need to export a snapshot and hold-on to it while sub-processes are running, but never executes SQL itself so won't need to import a snapshot in its own transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pgsql.c for the case when we fail to execute a SQL command without parameters, such as e.g. the very simple "COMMIT;" command. First, we might not be given a SQLSTATE, and second, we need to pay attention about that lack of debugParameters.
Also improve
pgcopydb clonecommand to avoid importing a snapshot in the top-level process. This process might need to export a snapshot and hold-on to it while sub-processes are running, but never executes SQL itself so won't need to import a snapshot in its own transaction.