Fix stream_transform_resume to share context with stream_transform_file. 8000 #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resuming operations from pre-existing files on-disk, we implement some cache invalidation by transforming the JSON file again from scratch, and tracking progress in our internal data structures. That's needed in case the previous version of the file terminates in the middle of a transaction rather than at a clean transaction boundary. The previous approach missed that the internal tracking state kept in the StreamContext instance was not shared. Now it is.
As seen in the logs:
ERROR ld_transform.c:1689 Failed to write to stream: Bad file descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot
2C65
be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resuming operations from pre-existing files on-disk, we implement some cache invalidation by transforming the JSON file again from scratch, and tracking progress in our internal data structures.
That's needed in case the previous version of the file terminates in the middle of a transaction rather than at a clean transaction boundary.
The previous approach missed that the internal tracking state kept in the StreamContext instance was not shared. Now it is.
See #354.
See #348.
See #331.