Fix a couple bugs in pgcopydb clone --follow. #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, when interrupting the pgcopydb process interactively with C-c while the transform process is running, we should exit the follow loop cleanup. Second, when using pgcopydb clone --follow --restart we should do a replication setup cleanup first, the same as the pgcopydb stream cleanup command, so that we can actually restart from scratch as the command says.
5af0cab to
f4b45ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, when interrupting the pgcopydb process interactively with C-c while the transform process is running, we should exit the follow loop cleanup.
Second, when using pgcopydb clone --follow --restart we should do a replication setup cleanup first, the same as the pgcopydb stream cleanup command, so that we can actually restart from scratch as the command says.