8000 Voice processor: add back call to set stream delay by jacquescomeaux · Pull Request #1701 · dino/dino · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Voice processor: add back call to set stream delay #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Voice processor: add back call to set stream delay #1701

merged 1 commit into from
May 23, 2025

Conversation

jacquescomeaux
Copy link
Contributor

This should fix #1700, assuming the one line of code mentioned there was indeed removed by accident. I've tested this and it makes the static noise go away

@mar-v-in
Copy link
Member

Hi. The change you did is in the ifdef block for webrtc-audio-processing-0. If available, Dino will use the newer webrtc-audio-processing-1 or -2. Which OS and version of webrtc-audio-processing did you test this against?

@jacquescomeaux
Copy link
Contributor Author

Hello. I tested this on artix linux. I just now tested again with and without the change to confirm the behavior. This time I commented out some lines in meson.build to make sure that webrtc-audio-processing-0.3 was chosen for both tests, and I confirmed that the output of meson setup build included this line

Dependency webrtc-audio-processing found: YES 0.3.1 (cached)

@Antiz96
Copy link
Antiz96 commented Apr 23, 2025

#1700 was due to a downstream packaging issue, as the dino Arch Linux package was compiled with the legacy webrtc-audio-processing-0.3 dependency. This is now fixed (https://gitlab.archlinux.org/archlinux/packaging/packages/dino/-/issues/5).

@fiaxh fiaxh merged commit 715b874 into dino:master May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loud static-like noise on calls with dino 0.5 using webrtc-audio-processing-0.3
4 participants
@jacquescomeaux @mar-v-in @Antiz96 @fiaxh
0