8000 [fix][dingo-calcite] Fix Index name ignores case when valiator by wt0530 · Pull Request #1463 · dingodb/dingo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[fix][dingo-calcite] Fix Index name ignores case when valiator #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2335,9 +2335,9 @@ private static List<IndexDefinition> getIndexDefinitions(
.filter(col -> col.getKind() == SqlKind.CREAT 10000 E_INDEX)
.map(col -> fromSqlIndexDeclaration((SqlIndexDeclaration) col, tableDefinition))
.collect(Collectors.toCollection(ArrayList::new)));
long count = tableDefList.stream().map(TableDefinition::getName).distinct().count();
long count = tableDefList.stream().map(c -> c.getName().toUpperCase()).distinct().count();
if (tableDefList.size() > count) {
throw new IllegalArgumentException("Duplicate index name");
throw DINGO_RESOURCE.duplicateColumn().ex();
}
return tableDefList;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ private Blackboard createInsertBlackboard(
rexBuilder.makeFieldAccess(sourceRef, j++));
}
}
return createBlackboard(null, nameToNameMap, false);
return createBlackboard(validator().getEmptyScope(), nameToNameMap, false);
}

private SqlValidator validator() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
writer.keyword("USAGE");
}
writer.keyword("ON");
writer.keyword(schema);
writer.literal(schema);
writer.keyword(".");
writer.keyword(table);
writer.literal(table);
writer.keyword("TO");
writer.keyword(user);
writer.literal(user);
writer.keyword("@");
writer.keyword(host);
if (withGrantOption) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.calcite.rel.type.RelDataTypeFieldImpl;
import org.apache.calcite.rex.RexNode;
import org.apache.calcite.sql.type.SqlTypeName;
import org.apache.calcite.util.IndexColumnName;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;

Expand Down Expand Up @@ -117,7 +118,7 @@ public RelDataType getTableType() {
RelDataTypeFactory.Builder builder = getCluster().getTypeFactory().builder();
builder.addAll(relDataType.getFieldList());
builder.add(new RelDataTypeFieldImpl(
indexTable.getName() + "$rank_bm25",
indexTable.getName() + IndexColumnName.TEXT_INDEX_COLUMN,
relDataType.getFieldCount(),
getCluster().getTypeFactory().createSqlType(SqlTypeName.get("FLOAT"))));
return builder.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.apache.calcite.rex.RexNode;
import org.apache.calcite.sql.SqlCharStringLiteral;
import org.apache.calcite.sql.type.SqlTypeName;
import org.apache.calcite.util.IndexColumnName;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;

Expand Down Expand Up @@ -186,7 +187,7 @@ public RelDataType getTableType() {
RelDataTypeFactory.Builder builder = getCluster().getTypeFactory().builder();
builder.addAll(relDataType.getFieldList());
builder.add(new RelDataTypeFieldImpl(
indexTable.getName() + "$rank_bm25",
indexTable.getName() + IndexColumnName.TEXT_INDEX_COLUMN,
relDataType.getFieldCount(),
getCluster().getTypeFactory().createSqlType(SqlTypeName.get("FLOAT"))));
return builder.build();
Expand All @@ -199,7 +200,7 @@ public TupleType tupleType() {
cols.addAll(dingoTable.getTable().columns);
cols.add(Column
.builder()
.name(indexTable.getName().concat("$rank_bm25"))
.name(indexTable.getName().concat(IndexColumnName.VECTOR_INDEX_COLUMN))
.sqlTypeName("FLOAT")
.type(new FloatType(false))
.precision(-1)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.apache.calcite.sql2rel.SqlDocumentOperator;
import org.apache.calcite.sql2rel.SqlFunctionScanOperator;
import org.apache.calcite.sql2rel.SqlVectorOperator;
import org.apache.calcite.util.IndexColumnName;
import org.checkerframework.checker.nullness.qual.Nullable;

import java.util.ArrayList;
Expand Down Expand Up @@ -102,7 +103,7 @@ protected RelDataType validateImpl(RelDataType targetRowType) {
}
cols.add(Column
.builder()
.name(index.getName().concat("$distance"))
.name(index.getName().concat(IndexColumnName.VECTOR_INDEX_COLUMN))
.sqlTypeName("FLOAT")
.type(new FloatType(false))
.precision(-1)
Expand All @@ -128,7 +129,7 @@ protected RelDataType validateImpl(RelDataType targetRowType) {
this.index = getDocumentIndexTable(table, columnIdentifier.getSimple().toUpperCase());
cols.add(Column
.builder()
.name(index.getName().concat("$rank_bm25"))
.name(index.getName().concat(IndexColumnName.TEXT_INDEX_COLUMN))
.sqlTypeName("FLOAT")
.type(new FloatType(false))
.precision(-1)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.apache.calcite.sql.SqlNode;
import org.apache.calcite.sql.SqlNumericLiteral;
import org.apache.calcite.sql2rel.SqlHybridSearchOperator;
import org.apache.calcite.util.IndexColumnName;
import org.checkerframework.checker.nullness.qual.Nullable;

import java.math.BigDecimal;
Expand Down Expand Up @@ -168,11 +169,11 @@ protected RelDataType validateImpl(RelDataType targetRowType) {
// throw new RuntimeException("Multiple hybridSearch in SQL is not supported");
//}
String documentId = documentIndex.getColumns().get(0).getName();
String documentRankBm25 = documentIndex.getName() + "$rank_bm25";
String documentRankBm25 = documentIndex.getName() + IndexColumnName.TEXT_INDEX_COLUMN;
String documentSelect = this.function.operand(0).toString();
String vectorSelect = this.function.operand(1).toString();
String vectorId = vectorIndex.getColumns().get(0).getName();
String vectorDistance = vectorIndex.getName() + "$distance";
String vectorDistance = vectorIndex.getName() + IndexColumnName.VECTOR_INDEX_COLUMN;
String sql = HybridSearchSqlUtils.hybridSearchSqlReplace(
vectorWeight,
documentWeight,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public void createUser(UserDefinition userDefinition) {

@Override
public void dropUser(UserDefinition userDefinition) {
String condition = "user ='" + userDefinition.getUser() + "' and host ='" + userDefinition.getHost() + "'";
String condition = "User ='" + userDefinition.getUser() + "' and Host ='" + userDefinition.getHost() + "'";
String delUserSql = "delete from mysql.user where " + condition;
String delDbSql = "delete from mysql.db where " + condition;
String delTablesPrivSql = "delete from mysql.tables_priv where " + condition;
Expand Down
0