8000 refactor!: replace `isAnySelectMenu` with `isSelectMenu` by sdanialraza · Pull Request #10656 · discordjs/discord.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor!: replace isAnySelectMenu with isSelectMenu #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

refactor!: replace isAnySelectMenu with isSelectMenu #10656

merged 2 commits into from
Dec 12, 2024

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Replaces BaseInteraction#isAnySelectMenu() with BaseInteraction#isSelectMenu(). Internal discussion here

BREAKING CHANGE: BaseInteraction#isAnySelectMenu() has been removed. Use BaseInteraction#isSelectMenu() instead.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@sdanialraza sdanialraza requested a review from a team as a code owner December 12, 2024 05:06
@vercel Vercel
Copy link
vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 10:14am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 10:14am

@sdanialraza sdanialraza force-pushed the refactor/replace-isanyselectmenu-isselectmenu branch from f03c6ec to a873a96 Compare December 12, 2024 08:59
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Dec 12, 2024
@Jiralite Jiralite merged commit fd1958b into discordjs:main Dec 12, 2024
7 checks passed
@sdanialraza sdanialraza deleted the refactor/replace-isanyselectmenu-isselectmenu branch December 12, 2024 10:25
@Jiralite Jiralite mentioned this pull request Dec 19, 2024
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js refactor semver:major
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sdanialraza @vladfrangu @didinele @Jiralite
0