8000 ReferenceError: proxyOptions is not defined · Issue #260 · distubejs/ytdl-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ReferenceError: proxyOptions is not defined #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dagyu opened this issue May 16, 2025 · 1 comment · May be fixed by #261
Open

ReferenceError: proxyOptions is not defined #260

dagyu opened this issue May 16, 2025 · 1 comment · May be fixed by #261
Labels
bug Something isn't working

Comments

@dagyu
Copy link
dagyu commented May 16, 2025

Please can you fix this bug as soon as possible, the bug is really easy to fix you have changed the name into options bug at line 93 you still pass a variable called proxyOptions so it doesn't work

ytdl-core/lib/agent.js

Lines 83 to 96 in 1f19fe0

exports.createProxyAgent = (options, cookies = []) => {
if (!cookies) cookies = [];
if (typeof options === "string") options = { uri: options };
const jar = new CookieJar();
addCookies(jar, cookies);
// ProxyAgent type that node httplibrary supports
const agent = new HttpsProxyAgent(options.uri);
// ProxyAgent type that undici supports
const dispatcher = new ProxyAgent(proxyOptions).compose(cookie({ jar }));
return { dispatcher, agent, jar, localAddress: options.localAddress };
};

@dagyu dagyu added the bug Something isn't working label May 16, 2025
1ly4s0 added a commit to 1ly4s0/ytdl-core that referenced this issue May 16, 2025
@1ly4s0
fix(proxy): use correct options object in createProxyAgent (distubejs…
cf21397 
…#260)
@1ly4s0 1ly4s0 linked a pull request May 16, 2025 that will close this issue
Open
@1ly4s0
Copy link
1ly4s0 commented May 16, 2025

PR has been added in #261, thanks a lot for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix proxy: use correct options object in createProxyAgent (#260) 1ly4s0/ytdl-core
2 participants
@dagyu @1ly4s0
0