chore: generate authors and update mailmap #4215
Conversation
There was a problem hiding this comment.
This is wildly outdated. The alpha release we just cut had so many people on the list that the release-tool barfed and I had to patch it. It's not parsing emails from PRs or something, so we decided not to update the list.
I would prefer to chuck this file completely. I'm not even sure what is it used for 🤔
I think you mean the authors file not mailmap. In this case this is for the contributions graph to match accordingly on GitHub and also have a proper git log. |
4e4033c to
252c836
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6dab1b6 to
e285b2c
Compare
No I meant the distribution/releases/v3.0.0.toml Lines 2472 to 2842 in 012adca .mailmap
The contributor list is a list of names, not GH handles, missing email addresses. Those contributors should be technically added to Maybe something like this could do the job if you fancy it? git log --format='%aN <%aE>' | sort -fu |
|
Ah ok got it now. I see on containerd repo it's kept updated after each release notes: https://github.com/containerd/containerd/commits/main/.mailmap |
|
Yes it is, but as I said, this was the first release in millennia for this project so the list was ginormous and the tool we usually use for this barfed like if it had eaten some gone off food. As I said, the |
|
The |
Can you point me in some direction where I can learn more about this? What happens if that map grows beyond belief? What code reads it? How? Does it require a specific format? etc. I've more questions than the presents I got this xmas. |
|
Some comment here; https://github.com/moby/moby/blob/46f7ab808b9504d735d600e259ca0723f76fb164/.mailmap#L1-L8 And the |
|
We need something like https://github.com/moby/moby/blob/46f7ab808b9504d735d600e259ca0723f76fb164/hack/generate-authors.sh The original command I suggested above wasn't far off 😄 This needs work for sure.... |
I have this branch if you're interested in crazy-max@6af1e67 |
|
PR it @crazy-max 😄 |
e285b2c to
44c3e8f
Compare
|
@milosgajdos Pushed changes here. As best effort I took linked authors from https://github.com/moby/moby/blob/master/.mailmap and https://github.com/containerd/containerd/blob/main/.mailmap |
| Victor Vieux <victor.vieux@docker.com> <vieux@docker.com> | ||
| Vincent Batts <vbatts@redhat.com> | ||
| Vincent Batts <vbatts@redhat.com> <vbatts@hashbangbash.com> | ||
| Vincent Demeester <vincent.demeester@docker.com> |
There was a problem hiding this comment.
This one probably needs an update to a current e-mail (I see we need the same on docker/cli)
There was a problem hiding this comment.
Do you have any suggestions for how to do this? I believe it should stay as is because the contribution as recorded in the git commit tree was made with the email address as stated above. Otherwise we're down the world of INTENSE pain of querying GH API.
There was a problem hiding this comment.
I wouldn't bother too much, but there's a bunch in this one that I'm aware of (former colleagues and such). Removing duplicates may be more relevant to get a (somewhat) accurate list of authors.
There was a problem hiding this comment.
Yeah, I agree RE: removing dupes. That's a solvable problem, searching for up-to-date email addresses I would not bother with.
There was a problem hiding this comment.
Yup. I might do a follow-up to set a reasonable baseline (fixing the ones I'm aware of), but after that we can limit to / focus on just removing duplicates (which are easier to spot).
FWIW; CNCF also maintains a database for this purpose, where they try to centrally map aliases etc for their stats (it's being replaced with some other internal tool though); https://github.com/cncf/devstats
44c3e8f to
6ab7a26
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6ab7a26 to
587f9e2
Compare
There was a problem hiding this comment.
I'm giving this a preemptive approval because it's already great and I don't want this to end up being blocked and chased by someone who wants to merge this PR in. PTAL @thaJeztah and merge when happy.
Generate authors and update mailmap. As best effort I took linked authors from https://github.com/moby/moby/blob/master/.mailmap and https://github.com/containerd/containerd/blob/main/.mailmap