8000 refactor(storage/s3): remove redundant len check by Juneezee · Pull Request #4259 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(storage/s3): remove redundant len check #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

refactor(storage/s3): remove redundant len check #4259

merged 1 commit into from
Jan 18, 2024

Conversation

Juneezee
Copy link
Contributor
@Juneezee Juneezee commented Jan 17, 2024 •
edited
Loading

A small code refactoring.

len(dirs) > 0 is redundant because range already skips empty slice.

@Juneezee
refactor(storage/s3): remove redundant len check
41161a6 
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
wy65701436
wy65701436 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos milosgajdos merged commit 0b21cc0 into distribution:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamstah Jamstah Jamstah approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees
No one assigned
Labels
area/storage/s3 area/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Juneezee @Jamstah @wy65701436 @milosgajdos
0