Include headers when serving blob through proxy #4273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 1795292 we updated ServeBlob() to use an io.MultiWriter to write simultaneously to the local store and the HTTP response. However, copyContent was using a type assertion to only add headers if the io.Writer was a http.ResponseWriter. Therefore, this change caused us to stop sending the expected headers (i.e. Content-Length, Etag, etc.) on the first request for a blob. Resolve the issue by explicitly passing in http.Header and setting it unconditionally. Signed-off-by: Mikel Rychliski <mikel@mikelr.com>
e82ac3b to
0418245
Compare
|
/cc @milosgajdos @Jamstah |
|
I'm going to close this and reopen as for some reason GH doesn't allow me to approve running the CI
|
milosgajdos
approved these changes
Mar 2, 2024
|
PTAL @thaJeztah @Jamstah @squizzi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 1795292 we updated ServeBlob() to use an io.MultiWriter to write simultaneously to the local store and the HTTP response.
However, copyContent was using a type assertion to only add headers if the io.Writer was a http.ResponseWriter. Therefore, this change caused us to stop sending the expected headers (i.e. Content-Length, Etag, etc.) on the first request for a blob.
Resolve the issue by explicitly passing in http.Header and setting it unconditionally.