8000 replace ListObjectsV2 with HeadObject to speed up Stat by ob-mc · Pull Request #4326 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

replace ListObjectsV2 with HeadObject to speed up Stat #4326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

replace ListObjectsV2 with HeadObject to speed up Stat #4326

wants to merge 2 commits into from

Conversation

ob-mc
Copy link
@ob-mc ob-mc commented Apr 16, 2024

replace listObject usr HeadObject can accelerate image push

@milosgajdos
Copy link
Member

@DHmc133 can you please

  1. Describe what you are trying to achieve and the motivations behind the PR
  2. Always sign your commit

Looks like there is a conflict that needs resolving

@ob-mc
Copy link
Author
ob-mc commented Apr 17, 2024

@DHmc133 can you please

  1. Describe what you are trying to achieve and the motivations behind the PR
  2. Always sign your commit

Looks like there is a conflict that needs resolving

We found that the listObject request will list the full amount of data to find the corresponding key, and the HeadObject can directly get the key's attributes;
Generally speaking, in large image scenarios, it can effectively improve the speed of image push.

@milosgajdos
Copy link
Member

@DHmc133 your PR is broken and fails to build. As I said, you also need to sign your commit.

@squizzi
Copy link
Collaborator
squizzi commented Apr 22, 2024

@DHmc133 please update your commit as well... Update s3.go isn't a good commit message, please follow the conventional commits spec as well when writing your commit. Perhaps something like:

perf: replace ListObjectsV2 with HeadObject to speed up Stat

@ob-mc ob-mc changed the title Update s3.go replace ListObjectsV2 with HeadObject to speed up Stat Apr 25, 2024
@milosgajdos
Copy link
Member

this needs a rebase @DHmc133 and commit signature

@ob-mc
Merge branch 'main' into main
1ba51c3 
Signed-off-by: DHmc133 <98294423+DHmc133@users.noreply.github.com>
ob-mc

This comment was marked as duplicate.

Sign in to view

@milosgajdos
Copy link
Member

This broke the build now. And it's still missing the commit signature.

@milosgajdos milosgajdos mentioned this pull request Jul 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/storage/s3 area/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ob-mc @milosgajdos @squizzi
0