Remove deprecated version field #4459
Conversation
https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/ Signed-off-by: Tibor <tiborcasteleijn@gmail.com>
There was a problem hiding this comment.
LGTM, just adding this link for reference to compose spec: https://github.com/compose-spec/compose-spec/blob/main/04-version-and-name.md#version-top-level-element-obsolete
|
Looks like the example is still written for compose v1 ( |
|
@tiborrr mind updating distribution/docs/content/recipes/nginx.md Lines 193 to 195 in 4615d30 |
|
Looks like there's a couple of other places as well; git grep 'docker-compose[^\.-]'
docs/content/about/deploying.md:$ docker-compose up -d
docs/content/recipes/apache.md:$ docker-compose up -d
docs/content/recipes/nginx.md:$ docker-compose up -d
releases/v3.0.0-alpha.1.toml:* Use docker-compose spec v3 in nginx receipt ([#3872](https://github.com/distribution/distribution/pull/3872))
releases/v3.0.0-alpha.1.toml: * [`c624b9ed`](https://github.com/distribution/distribution/commit/c624b9eda7d193856216ee0013468777a16f2e8a) Use docker-compose spec v3 in nginx receipt |
|
|
Signed-off-by: Tibor <tiborcasteleijn@gmail.com>
Signed-off-by: Tibor <tiborcasteleijn@gmail.com>
Signed-off-by: Tibor <tiborcasteleijn@gmail.com>
|
@thaJeztah can you approve this pull request with the changes I have made? |
https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/