8000 registry/storage: add option to quiet GC output. by r4f4 · Pull Request #4560 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

registry/storage: add option to quiet GC output. #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

registry/storage: add option to quiet GC output. #4560

merged 2 commits into from
Feb 13, 2025

Conversation

r4f4
Copy link
Contributor
@r4f4 r4f4 commented Jan 31, 2025

Consumers might not want GC output to be displayed (e.g, if you have your own logging system).

@r4f4 r4f4 force-pushed the garbage-collect-quiet branch from 1c439a2 to 5c98929 Compare January 31, 2025 16:08
milosgajdos
milosgajdos reviewed Feb 2, 2025
View reviewed changes
Copy link
Member
@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incomplete. You need to pass the Quiet setting to GC somehow:
likely through

distribution/registry/root.go

Line 45 in 7271d88

var GCCmd = &cobra.Command{

@r4f4
registry/storage: add option to quiet GC output.
a032989 
Consumers might not want GC output to be displayed (e.g, if you have
your own logging system).

Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
@r4f4 r4f4 force-pushed the garbage-collect-quiet branch from 5c98929 to a032989 Compare February 2, 2025 09:19
@r4f4
Copy link
Contributor Author
r4f4 commented Feb 2, 2025

Done:

 $ ./bin/registry garbage-collect --help
`garbage-collect` deletes layers not referenced by any manifests

Usage:
  registry garbage-collect <config> [flags]

Flags:
  -m, --delete-untagged   delete manifests that are not currently referenced via tag
  -d, --dry-run           do everything except remove the blobs
  -h, --help              help for garbage-collect
  -q, --quiet             silence output

milosgajdos
milosgajdos reviewed Feb 2, 2025
View reviewed changes
Copy link
Member
@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine now, but I think we should update the docs, too.
Sorry about not mentioning this on the previous review but would you mind mentioning the new cli switch in

distribution/docs/content/about/garbage-collection.md

Line 89 in 7271d88

## Run garbage collection

@r4f4
docs/garbage-collection: document --delete-untagged and --quiet options
2a491b3 
Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
@r4f4
Copy link
Contributor Author
r4f4 commented Feb 3, 2025 •
edited
Loading

The code is fine now, but I think we should update the docs, too. Sorry about not mentioning this on the previous review but would you mind mentioning the new cli switch in

distribution/docs/content/about/garbage-collection.md

Line 89 in 7271d88

## Run garbage collection

Good call. I've added --delete-untagged and --quiet to the garbage-collection docs.

milosgajdos
milosgajdos approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member
@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @thaJeztah @Jamstah @davidspek

wy65701436
wy65701436 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos milosgajdos merged commit 63d3892 into distribution:main Feb 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees
No one assigned
Labels
area/docs area/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r4f4 @milosgajdos @wy65701436
0