8000 Documentation: Added '*' to action in "Resource Scope Grammar" by TrodelHD · Pull Request #4561 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Documentation: Added '*' to action in "Resource Scope Grammar" #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Documentation: Added '*' to action in "Resource Scope Grammar" #4561

wants to merge 1 commit into from
+1 −1

Conversation

TrodelHD
Copy link
@TrodelHD TrodelHD commented Feb 2, 2025

Documentation: Added '*' to action in "Resource Scope Grammar" because a catalog request requires it.

Issue: #4559

Documentation: Added '*' to action in "Resource Scope Grammar"
d196106 
               because a catalog request requires it.

Signed-off-by: Peter Stolpe <peter.stolpe@drehpunkt.com>
@TrodelHD TrodelHD mentioned this pull request Feb 2, 2025
Open
@milosgajdos
Copy link
Member

PTAL @thaJeztah

thaJeztah
thaJeztah reviewed Apr 4, 2025
View reviewed changes
docs/content/spec/auth/scope.md
action := /[a-z]*/
action := /[a-z*]*/
Copy link
Member
@thaJeztah thaJeztah Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if a more accurate presentation would be [a-z]* OR *, because the suggested change here would also consider p*u***l*l to be valid, and I'm not sure if that was the intent here.

@thaJeztah
Copy link
Member

Even wondering now if the * was intentionally out of spec, because it was not meant to be user-accessible #653 (comment)

The catalog API is considered an administration function. This is protected by a JWT access record with type="registry", name="catalog" and access="*" for the standard distribution/auth package. This is covered in the app.go portion of this PR. Other implementations may choose to use a more or less granular access model, but this endpoint is not meant for end users.

If you have suggestions here, they would be appreciated, but this is a little late in the design process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@milosgajdos milosgajdos milosgajdos approved these changes

@Vad1mo Vad1mo Vad1mo approved these changes

@Jamstah Jamstah Awaiting requested review from Jamstah

@joaodrp joaodrp Awaiting requested review from joaodrp

@wy65701436 wy65701436 Awaiting requested review from wy65701436

@squizzi squizzi Awaiting requested review from squizzi

@deleteriousEffect deleteriousEffect Awaiting requested review from deleteriousEffect

@davidspek davidspek Awaiting requested review from davidspek

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrodelHD @milosgajdos @thaJeztah @Vad1mo
0