8000 Bump Go version in prep for a release by milosgajdos · Pull Request #4601 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Go version in prep for a release #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

milosgajdos
Copy link
Member

This bumps the Go version in prep for the next release.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file area/ci area/build labels Mar 18, 2025
Comment on lines +36 to +37
- 1.23.7
- 1.24.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to go1.23 for now; there's multiple regressions we ran into with go1.24, and they happen .. in non-obvious ways;

Copy link
Member Author
@milosgajdos milosgajdos Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having this in CI matrix is fine, but yeah, will change the Dockerfiles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, CI is ok for sure. It's indeed for the releases that I don't know if we'd hit it; more so because there's no clear reproducer yet, so users may hit it randomly, which isn't .. great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK dropped it back to 1.23.7 everywhere except the CI. PTAL

@milosgajdos milosgajdos changed the title Bump Go version in prep for a releass Bump Go version in prep for a release Mar 18, 2025
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there's a typo in the last commit message though ☺️

This bumps the Go version in preparation for the next release.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
@milosgajdos
Copy link
Member Author

there's a typo in the last commit message though ☺️

I'm partially dyslexic so often miss these. Thanks, I've squashed and fixed the commit message.

@milosgajdos milosgajdos merged commit fb71a0a into distribution:main Mar 19, 2025
21 checks passed
@milosgajdos milosgajdos deleted the bump-go-version branch March 19, 2025 14:58
benoittgt added a commit to benoittgt/helm that referenced this pull request Apr 11, 2025
```
» go mod download
go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8
```

We need to update Go, because of distribution/distribution#4601
benoittgt added a commit to benoittgt/helm that referenced this pull request Apr 11, 2025
```
» go mod download
go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8
```

We need to update Go, because of distribution/distribution#4601

Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/ci dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0