-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bump Go version in prep for a release #4601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 1.23.7 | ||
- 1.24.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd stick to go1.23 for now; there's multiple regressions we ran into with go1.24, and they happen .. in non-obvious ways;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having this in CI matrix is fine, but yeah, will change the Dockerfiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, CI is ok for sure. It's indeed for the releases that I don't know if we'd hit it; more so because there's no clear reproducer yet, so users may hit it randomly, which isn't .. great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK dropped it back to 1.23.7 everywhere except the CI. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
there's a typo in the last commit message though
This bumps the Go version in preparation for the next release. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
e518139
to
d7b8fb6
Compare
I'm partially dyslexic so often miss these. Thanks, I've squashed and fixed the commit message. |
``` » go mod download go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8 ``` We need to update Go, because of distribution/distribution#4601
``` » go mod download go: module github.com/distribution/distribution/v3@v3.0.0 requires go >= 1.23.7; switching to go1.23.8 ``` We need to update Go, because of distribution/distribution#4601 Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
This bumps the Go version in prep for the next release.