8000 fix: implement JWK thumbprint for Ed25519 public keys by zhangyoufu · Pull Request #4626 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: implement JWK thumbprint for Ed25519 public keys #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix: implement JWK thumbprint for Ed25519 public keys #4626

merged 1 commit into from
Apr 23, 2025

Conversation

zhangyoufu
Copy link
Contributor
@zhangyoufu zhangyoufu commented Apr 18, 2025 •
edited
Loading

In #4471, we implemented JWK fingerprint for RSA and ECDSA public keys, in accordance to RFC 7638.
This PR implemented JWK fingerprint for Ed25519 public keys, in accordance to RFC 8037.

@milosgajdos
Copy link
Member

Please sign your DCO @zhangyoufu

@zhangyoufu zhangyoufu force-pushed the Ed25519 branch 2 times, most recently from 2fcf05f to 7a4fec6 Compare April 18, 2025 11:44
@zhangyoufu
Copy link
Contributor Author

Please sign your DCO @zhangyoufu

@milosgajdos DCO done. Force-pushed. Workflows awaiting approval.

milosgajdos
milosgajdos approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member
@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL @thaJeztah

thaJeztah
thaJeztah reviewed Apr 22, 2025
View reviewed changes
thaJeztah
thaJeztah reviewed Apr 22, 2025
View reviewed changes
@zhangyoufu
fix: implement JWK thumbprint for Ed25519 public keys
4aab88f 
Signed-off-by: Youfu Zhang <zhangyoufu@gmail.com>
thaJeztah
thaJeztah approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milosgajdos milosgajdos merged commit e827ce2 into distribution:main Apr 23, 2025
21 checks passed
@zhangyoufu zhangyoufu deleted the Ed25519 branch April 23, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
area/auth area/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangyoufu @milosgajdos @thaJeztah
0