8000 feat: extract redis config to separate struct by shanduur · Pull Request #4620 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: extract redis config to separate struct #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

shanduur
Copy link
Contributor

This PR introduces a dedicated RedisOptions struct to encapsulate Redis client configuration in a clean, reusable, and extensible way. This change promotes better separation of concerns, easier testing, and improved readability of configuration-related code.

Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
@github-actions github-actions bot added area/config Related to registry config area/api labels Apr 10, 2025
Copy link
Member
@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it a bit harder to keep up with Redis module, but maybe that's ok for stability sake

Copy link
Collaborator
@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@milosgajdos milosgajdos merged commit 95647cb into distribution:main Apr 29, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/config Related to registry config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0