docs: pull through cache will pull from remote multiple times #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign your commit please. |
Summary: We see from the code and code comment in proxyblobstore.go that: "If the blob has been serving in other requests. Will return the blob from the remote store directly". That means concurrent pulls will pull from remote multiple times. Signed-off-by: Sam Jia <yiyunj@twitter.com>
f9b63e9 to
8a5addf
Compare
Oops, signed with personal email, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We see from the code and code comment in proxyblobstore.go that: "If the blob has been serving in other requests. Will return the blob from the remote store directly". That means concurrent pulls will pull from remote multiple times. The original docs says "concurrent requests do not pull duplicate data", which was confusing.