feat(proxy): LRU eviction policy for pull through cache #4663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign your commit, please |
Summary: This is a preliminary step to adding other eviction policies. TTL is a TTLScheduler-specifc variable and should belong within that scope, not exported to each component. Signed-off-by: Sam Jia <yiyunj@twitter.com>
31a2d85 to
4851e0f
Compare
Oops, signed with personal email, updated. |
added 4 commits
July 1, 2025 12:46
Summary: We need a general eviction interface to support multiple eviction policies. This commit does two thing: - Change configurations to support multiple eviction policies - Change ttl scheduler to be a general eviction interface, and make ttl scheduler implement this eviction policy Signed-off-by: Sam Jia <yiyunj@twitter.com>
Summary: This is yet another supporting revision to the final LRU eviction controller. We add the Usage call to storage drivers to find disk usage statistics at any given path under the storage driver. Signed-off-by: Sam Jia <yiyunj@twitter.com>
Summary: A preparatory revision to add file size parsing package: c2h5oh/datasize Signed-off-by: Sam Jia <yiyunj@twitter.com>
Summary: After consideration, we decided that the TTL scheduler is an unsafe eviction policy as it could overuse disk space, causing cache pods to be evicted and rescheduled, losing all cached entries. This commit implements an LRU eviction policy, which allows cache entries to persist until eviction is absolutely necessary, at which time the least recent entry is removed. Signed-off-by: Sam Jia <yiyunj@twitter.com>
4851e0f to
b0648f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr implements an LRU eviction policy for the pull through cache.
Motivation
As per discussion in #1140, because the TTL scheduler is not aware of the storage usage of the proxy (among other problems), it would be nice to have something like a least-recently-used heuristic for eviction.
Changes
The commits are made to be isolated for ease of review.
A list of rough changes:
duis used here because there's no good package that does this (everything usesstatfswhich is not right). This is fine for now since only linux is supported anyways and this works in the environment from Dockerfile.