Use reference package internally #1270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most places in the registry were using string types to refer to repository names. This changes them to use reference.Named, so the type system can enforce validation of the naming rules. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
LGTM |
| @@ -23,8 +24,8 @@ var _ Listener = &bridge{} | |||
|
|
|||
| // URLBuilder defines a subset of url builder to be used by the event listener. | |||
| type URLBuilder interface { | |||
| BuildManifestURL(name, tag string) (string, error) | |||
| BuildBlobURL(name string, dgst digest.Digest) (string, error) | |||
| BuildManifestURL(name reference.Named, tag string) (string, error) | |||
There was a problem hiding this comment.
Should this be reference.Tagged?
There was a problem hiding this comment.
It should take reference.NamedTagged, and BuildBlobURL should take reference.Canonical. I'll make these changes.
There was a problem hiding this comment.
I've implemented this change at https://github.com/aaronlehmann/distribution/tree/use-reference-package-v2. It depends on #1268 and #1271, so I'm going to close this PR for now and reopen it when those PRs are merged.
(Slight correction to the above: BuildManifestURL will take a single reference.Named that may include a digest or tag.)
|
GitHub isn't letting me reopen this pull request with an updated branch. I've opened #1333 to replace this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most places in the registry were using string types to refer to
repository names. This changes them to use reference.Named, so the type
system can enforce validation of the naming rules.
cc @dmcgowan @stevvooe