8000 Remove tags referencing deleted manifests. by RichardScothern · Pull Request #1319 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove tags referencing deleted manifests. #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2016
Merged

Remove tags referencing deleted manifests. #1319

merged 1 commit into from
Jan 11, 2016

Conversation

RichardScothern
Copy link

When a manifest is deleted by digest, look up the referenced tags in the tag
store and remove all associations.

closes #1293
closes #938
supercedes #1297

Signed-off-by: Richard Scothern richard.scothern@gmail.com

@rscothern
Remove tags referencing deleted manifests.
94347c8 
When a manifest is deleted by digest, look up the referenced tags in the tag
store and remove all associations.

Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
@RichardScothern RichardScothern mentioned this pull request Jan 5, 2016
Closed
@codecov-io
Copy link

Current coverage is 57.59%

Merging #1319 into master will decrease coverage by -0.04% as of 94347c8

@@            master   #1319   diff @@
======================================
  Files          116     116       
  Stmts        10472   10508    +36
  Branches       719     721     +2
  Methods          0       0       
======================================
+ Hit           6036    6052    +16
- Partial        719     721     +2
- Missed        3717    3735    +18

Review entire Coverage Diff as of 94347c8

Uncovered Suggestions

  1. +0.30% via ...ge/driver/gcs/gcs.go#185...216
  2. +0.30% via ...ge/driver/gcs/gcs.go#104...135
  3. +0.23% via ...ge/driver/gcs/gcs.go#469...492
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@stevvooe
Copy link
Collaborator
stevvooe commented Jan 7, 2016

@RichardScothern LGTM on this one.

Let's hold off on merging before we do schema2 merge. It will likely need a rebase.

@RichardScothern RichardScothern added this to the Registry/2.3 milestone Jan 11, 2016
RichardScothern pushed a commit that referenced this pull request Jan 11, 2016
Merge pull request #1319 from RichardScothern/update-tags
3a1220d 
Remove tags referencing deleted manifests.
@RichardScothern RichardScothern merged commit 3a1220d into distribution:master Jan 11, 2016
@aaronlehmann
Copy link
Contributor

This broke registry/handlers/api_test.go. #1281 changed some things in this file, and the changes here need to be brought up to date.

@RichardScothern RichardScothern deleted the update-tags branch February 5, 2016 18:31
thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Apr 22, 2021
Merge pull request distribution#1319 from RichardScothern/update-tags
e41a2d4 
Remove tags referencing deleted manifests.
thaJeztah pushed a commit to thaJeztah/distribution that referenced this pull request Jan 19, 2022
Merge pull request distribution#1319 from RichardScothern/update-tags
b7aee20 
Remove tags referencing deleted manifests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Registry/2.3
Development

Successfully merging this pull request may close these issues.

Tags list not updated after delete Manifest deletes need to cleanup tag index entry
6 participants
@RichardScothern @codecov-io @stevvooe @aaronlehmann @GordonTheTurtle @rscothern
0