fix panic when using storage redirect middleware #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Yang <windfarer@gmail.com>
Current coverage is 52.55% (diff: 100%)
@@ release/2.5 #2081 diff @@
=============================================
Files 120 120
Lines 10496 10496
Methods 0 0
Messages 0 0
Branches 0 0
=============================================
- Hits 6581 5516 -1065
- Misses 3038 4238 +1200
+ Partials 877 742 -135
|
|
We likely are not going to do a 2.5.2 release, the original change can be picked up in 2.6.0-rc1 by using the image |
|
@dmcgowan We cannot run an RC version in production environment. Could you tell me when is the release date of stable 2.6 version? Thanks a lot. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix panic when using storage redirect middleware in registry version 2.5.1
When we start registry with storage redirect middleware in config file, it will panic. The error message can be show as follows:
this PR fix this problem by importing storage redirect middleware in main.go