gha: also run tests #3520
Closed
gha: also run tests #3520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, travis was running 'check' (linting), and 'build', but none of the test targets were run. This patch adds the test targets to the github actions workflow. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Oct 27, 2021
Comment on lines
+53
to
+55
| make test-full | ||
| make test-race | ||
| make integration |
There was a problem hiding this comment.
Added some of the targets; perhaps we want a different combination and/or split these to separate steps in the action
|
Ah, I'm silly; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, travis was running 'check' (linting), and 'build', but
none of the test targets were run.
This patch adds the test targets to the github actions workflow.
Signed-off-by: Sebastiaan van Stijn github@gone.nl