8000 manifest/schema1: mark docker manifest v2, schema 1 deprecated by thaJeztah · Pull Request #3804 · distribution/distribution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

manifest/schema1: mark docker manifest v2, schema 1 deprecated #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

manifest/schema1: mark docker manifest v2, schema 1 deprecated #3804

merged 1 commit into from
Jan 30, 2023

Conversation

thaJeztah
Copy link
Member
@thaJeztah thaJeztah commented Nov 25, 2022 •
edited
Loading

Docker Image manifest v2, schema version 1 is deprecated since 2015, when manifest v2, schema version 2 was introduced (2e3f493 (#1068)).

Users should no longer use this specification other than for backward compatibility.

With this PR, all functions are highlighted as deprecated, and linters will trigger a deprecation warning when importing the package and when using any of these types or functions.

Screenshot 2022-11-25 at 17 12 36

@thaJeztah
Copy link
Member Author

@milosgajdos @justincormack ptal

@thaJeztah
Copy link
Member Author

oh! linters may fail on this if we still use any of these (in tests); I'll check if nolint comments are needed and update if that's the case.

@thaJeztah
Copy link
Member Author

🎉 CI is happy (phew)

@milosgajdos
Copy link
Member

Should probably add a comment here, too

distribution/configuration/configuration.go

Line 206 in ede90db

// Schema1 configures how schema1 manifests will be handled

@thaJeztah thaJeztah force-pushed the deprecate_schema1 branch 2 times, most recently from 14ec4e4 to 40c5b96 Compare November 26, 2022 11:59
@thaJeztah
Copy link
Member Author

Updated; also added a note to the documentation.

@thaJeztah
manifest/schema1: mark docker manifest v2, schema 1 deprecated
ff2bce2 
Docker Image manifest v2, schema version 1 is deprecated since 2015, when
manifest v2, schema version 2 was introduced (2e3f493).

Users should no longer use this specification other than for backward
compatibility.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@corhere ptal 🤗

deleteriousEffect
deleteriousEffect approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member
@deleteriousEffect deleteriousEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We might also want to consider logging a warning in the manifest handlers when we encounter a schema 1 image

@milosgajdos
Copy link
Member

We might also want to consider logging a warning in the manifest handlers when we encounter a schema 1 image

I would really like us to remove schema 1 image support completely from here.

@milosgajdos milosgajdos merged commit 9b62973 into distribution:main Jan 30, 2023
@thaJeztah thaJeztah deleted the deprecate_schema1 branch January 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corhere corhere corhere approved these changes

@milosgajdos milosgajdos milosgajdos approved these changes

@deleteriousEffect deleteriousEffect deleteriousEffect approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @milosgajdos @corhere @deleteriousEffect
0