8000 Fix types not being found by puckey · Pull Request #124 · ditojs/dito · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix types not being found #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

Fix types not being found #124

merged 1 commit into from
May 11, 2025

Conversation

puckey
Copy link
Contributor
@puckey puckey commented Oct 17, 2024

While upgrading to Node 22 icw pnpm I ran into a few issues where the Dito types weren't being found. This pr fixes things.

@lehni lehni force-pushed the master branch 2 times, most recently from de9dfe4 to 4262212 Compare May 4, 2025 11:01
@lehni
Copy link
Contributor
lehni commented May 11, 2025

@puckey only seeing this now, my apologies! Merging right away, I hope it'll still work

@lehni lehni merged commit 628019b into ditojs:master May 11, 2025
@lehni
Copy link
Contributor
lehni commented May 12, 2025

@puckey I'm getting these errors now when building. Could you take a look?

yarn build
▲ [WARNING] The condition "types" here will never be used as it comes after both "import" and "require" [package.json]

    package.json:15:6:
      15 │       "types": "./types/index.d.ts"
         ╵       ~~~~~~~

  The "import" condition comes earlier and will be used for all "import" statements:

    package.json:13:6:
      13 │       "import": "./dist/dito-admin.es.js",
         ╵       ~~~~~~~~

  The "require" condition comes earlier and will be used for all "require" calls:

    package.json:14:6:
      14 │       "require": "./dist/dito-admin.umd.js",
         ╵       ~~~~~~~~~

lehni added a commit that referenced this pull request May 12, 2025
@lehni
Fix exports warnings relating to "types" condition
69a6282 
Caused by #124
@lehni
Copy link
Contributor
lehni commented May 13, 2025

@puckey I hope 69a6282 works for you. It fixes the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puckey @lehni
0