Add Tarsum Calculation during v2 Pull operation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the v2 pull operation is writing the body of the layer blob to disk it now computes the tarsum checksum of the archive before extracting it to the backend storage driver. If the checksum does not match that from the image manifest an error is raised. Also adds more debug logging to the pull operation and fixes existing test cases which were failing. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
|
It passes the tests! I checked. |
| // Create a new TarSum using the provided TarSum version+hash label. | ||
| func NewTarSumForLabel(r io.Reader, disableCompression bool, label string) (TarSum, error) { | ||
| parts := strings.SplitN(label, "+", 2) | ||
| if len(parts) != 2 { |
There was a problem hiding this comment.
nm I was wrong https://play.golang.org/p/JhWAqEM7Al if curious
There was a problem hiding this comment.
er, I think it's at most 2, per the docs:
n > 0: at most n substrings; the last substring will be the unsplit remainder.
|
lgtm |
| @@ -39,6 +42,30 @@ func NewTarSumHash(r io.Reader, dc bool, v Version, tHash THash) (TarSum, error) | |||
| return ts, err | |||
| } | |||
|
|
|||
| // Create a new TarSum using the provided TarSum version+hash label. | |||
| func NewTarSumForLabel(r io.Reader, disableCompression bool, label string) (TarSum, error) { | |||
There was a problem hiding this comment.
I am not sure I am into this being a single function. I don't have a better suggestion at this time, so you can disregard my comment.
There was a problem hiding this comment.
I just added this to the tarsum package because there currently isn't a reverse lookup constructor >_>
|
LGTM! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the v2 pull operation is writing the body of the layer blob to disk
it now computes the tarsum checksum of the archive before extracting it to
the backend storage driver. If the checksum does not match that from the
image manifest an error is raised.
Also adds more debug logging to the pull operation and fixes existing test
cases which were failing.
Docker-DCO-1.1-Signed-off-by: Josh Hawn josh.hawn@docker.com (github: jlhawn)