8000 Add missing length check when reading label pointer by jtt · Pull Request #40 · dmachard/DNS-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add missing length check when reading label pointer #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2022
Merged

Add missing length check when reading label pointer #40

merged 2 commits into from
Feb 9, 2022

Conversation

jtt
Copy link
Contributor
@jtt jtt commented Feb 9, 2022

Fixes slice bounds out of range panic when parsing invalid DNS packet containing only first byte of label pointer.

Add unit test verifying that invalid label pointer is now detected and error is returned when it is being parsed.

@jtt jtt force-pushed the fix-out-of-bounds-label branch from 495de07 to 792350b Compare February 9, 2022 15:06
@dmachard
Copy link
Owner
dmachard commented Feb 9, 2022

many thanks for your fix.
Denis

@dmachard dmachard merged commit 661fd12 into dmachard:main Feb 9, 2022
@tmihaldinec tmihaldinec mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtt @dmachard
0