recorder: improve tests #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test only change. No functional change. Fixes dnaeon#119. - Use t.TempDir() instead of creating a temporary directory. The temporary directories were leaking. - Make tests parallel to shave 70ms off test runtime on my machine. Woohoo! - Add unit test for recording and playback with query parameters The test verifies that POST requests with query parameters (?foo=bar&baz=true) are properly recorded and can be replayed from cassette. This ensures both the recording phase captures the query parameters in the Form field and the playback phase returns the correct response without hitting the actual server. Co-Authored-By: sketch <hello@sketch.dev> Change-ID: s5b05187d5bf0a5c1k
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v4 #120 +/- ##
==========================================
+ Coverage 50.77% 51.38% +0.61%
==========================================
Files 4 4
Lines 648 648
==========================================
+ Hits 329 333 +4
+ Misses 299 295 -4
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dnaeon
requested changes
Jun 15, 2025
|
|
||
| // Phase 2: Test playback without the server running | ||
| // Stop the test server to ensure we're replaying from cassette | ||
| server.Close() |
There was a problem hiding this comment.
server will be closed already as deferred here.
| } | ||
| } | ||
|
|
||
| { |
There was a problem hiding this comment.
Any reason for the explicit scope introduced here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change. No functional change.
Fixes #119.
The test verifies that POST requests with query parameters (?foo=bar&baz=true) are properly recorded and can be replayed from cassette. This ensures both the recording phase captures the query parameters in the Form field and the playback phase returns the correct response without hitting the actual server.
Change-ID: s5b05187d5bf0a5c1k