bump Golang version to v1.22.10 and update CI actions #12399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Dec 18, 2024
.github/workflows/merge.yml
Outdated
| uses: tibdex/github-app-token@v1 | ||
| uses: tibdex/github-app-token@v2 |
There was a problem hiding this comment.
This is a 3rd party action, so potentially less "trusted"; wondering if this is one that we should pin to a commit? (also make sure that we evaluate the changes in the release).
Diff since last (v1.9.0) v1 release (but perhaps there's been other v1 updates since it was added); tibdex/github-app-token@v1.9.0...v2.1.0
There was a problem hiding this comment.
I pinned the version to the v2.1.0 commit
802b2a5 to
16ac8d1
Compare
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
16ac8d1 to
15b1e21
Compare
thaJeztah
reviewed
Dec 18, 2024
Comment on lines
-144
to
+146
| - 24.0.9 | ||
| - 25.0.5 | ||
| - 26.1.4 | ||
| - 27.4.0-rc.4 | ||
| - 27.4.1 |
There was a problem hiding this comment.
I just had a check if the script would be fine with that, but it looks like it is; it's possible to specify just 27.4 or even just 27, and it will pick the latest 27.4.x or 27.x.x. That may be ok to consider to not having to update for each minor or patch release.
I'll also check with @vvoland and @crazy-max to see if we can swap this out for our new docker-setup-action (https://github.com/docker/setup-docker-action), but that can definitely wait for separate for sure!
There was a problem hiding this comment.
Yep, it should work! It also supports master (with type=image,tag=master) so it could also be tested against here.
ndeloof
approved these changes
Dec 18, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jan 8, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.32.1` -> `v2.32.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.32.2`](https://github.com/docker/compose/releases/tag/v2.32.2) [Compare Source](docker/compose@v2.32.1...v2.32.2) #### What's Changed ##### ✨ Improvements - Add `--pull` to run command by [@​glours](https://github.com/glours) [(12397)](docker/compose#12397) ##### 🐛 Fixes - Only check bind mount conflict if sync action is involved by [@​ndeloof](https://github.com/ndeloof) [(12409)](docker/compose#12409) - When retrying to resolveOrCreateNetwork, retry with a valid network name by [@​gtardif](https://github.com/gtardif) [(12422)](docker/compose#12422) - checkExpectedVolumes must ignore anonymous volumes by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12410 ##### 🔧 Internal - Gofumpt all the things by [@​ndeloof](https://github.com/ndeloof) [(12392)](docker/compose#12392) - Use the 3 latest major versions of the engine to run e2e step by [@​glours](https://github.com/glours) [(12401)](docker/compose#12401) - Replace tibdex/github-app-token by official GitHub create-github-app-token by [@​glours](https://github.com/glours) [(12411)](docker/compose#12411) ##### ⚙️ Dependencies - Bump Golang version to `v1.22.10` and update CI actions by [@​glours](https://github.com/glours) [(12399)](docker/compose#12399) - Bump golang.org/x/net to `v0.33.0` to fix potential security issue by [@​glours](https://github.com/glours) [(12405)](docker/compose#12405) - Bump `compose-go` to `v2.4.7` by [@​glours](https://github.com/glours) [(12438)](docker/compose#12438) **Full Changelog**: docker/compose@v2.32.1...v2.32.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS40IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Bump Golang to
v1.22.10and update the different GitHub actionsRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did