8000 [20.10 backport] Stop slowing bash init by caching plugins path slowly by thaJeztah · Pull Request #4519 · docker/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[20.10 backport] Stop slowing bash init by caching plugins path slowly #4519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

[20.10 backport] Stop slowing bash init by caching plugins path slowly #4519

merged 1 commit into from
Aug 23, 2023

Conversation

thaJeztah
Copy link
Member

Fixes issue #3889 by only loading docker plugins path when needed: if it is fast enough than it shouldn't be a problem to do this on demand; OTOH if it is slow then we shouldn't do this during every bash session initialization, regardless if docker completion will be needed or not.

(cherry picked from commit 1da67be)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@guss77 @thaJeztah
Stop slowing bash init by caching plugins path slowly
a694904 
Fixes issue docker#3889 by only loading docker plugins path when needed: if it is fast enough than it shouldn't be a problem to do this on demand; OTOH if it is slow then we shouldn't do this during *every* bash session initialization, regardless if docker completion will be needed or not.

Signed-off-by: Oded Arbel <oded@geek.co.il>
(cherry picked from commit 1da67be)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 20.10.26 milestone Aug 23, 2023
@thaJeztah thaJeztah requested a review from albers as a code owner August 23, 2023 11:35
@thaJeztah thaJeztah mentioned this pull request Aug 23, 2023
Merged
@thaJeztah thaJeztah merged commit 12df1c1 into docker:20.10 Aug 23, 2023
@thaJeztah thaJeztah deleted the 20.10_backport_docker-cli-slows-bash-init branch August 23, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumpl rumpl rumpl approved these changes

@vvoland vvoland vvoland approved these changes

@albers albers Awaiting requested review from albers albers is a code owner

Assignees
No one assigned
Labels
area/completion area/performance kind/bugfix PR's that fix bugs status/2-code-review
Projects
None yet
Milestone
20.10.26
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @rumpl @vvoland @guss77
0