cli/command: use errors.Join instead of our own implementation #5791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own; also touch-up one error and some minor cleanups. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- pass through the manifest-store, instead of the CLI as a whole - handle context cancellation - rename `runRm` to `runRemove` to align with other commands Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Use stdlib multi-errors instead of creating our own - use apiClient instead of client for the API client to prevent shadowing imports. - use dockerCLI with Go's standard camelCase casing. - rename runSecretRemove to runRemove to align with other commands Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5791 +/- ##
==========================================
- Coverage 59.44% 59.41% -0.03%
==========================================
Files 347 347
Lines 29394 29346 -48
==========================================
- Hits 17472 17436 -36
+ Misses 10950 10937 -13
- Partials 972 973 +1 |
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Use stdlib multi-errors instead of creating our own Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Use stdlib multi-errors instead of creating our own - use apiClient instead of client for the API client to prevent shadowing imports. - use dockerCLI with Go's standard camelCase casing. - rewrite runServiceScale to return warnings, instead of printing them Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
61c94a2 to
81da375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli/command: use errors.Join instead of our own implementation
cli/command/config: RunConfigRemove: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/container: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/context: use errors.Join
Use stdlib multi-errors instead of creating our own; also
touch-up one error and some minor cleanups.
cli/command/image: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/inspect: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/manifest: pass manifest-store and handle context
runRmtorunRemoveto align with other commandscli/command/manifest: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/node: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/secret: use errors.Join
prevent shadowing imports.
cli/command/service: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/stack/swarm: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/volume: use errors.Join
Use stdlib multi-errors instead of creating our own
cli/command/service: runRollback: remove intermediate vars
cli/command/service: runScale: use errors.Join, and cleanup
prevent shadowing imports.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)