cli/connhelper: cleanups and test improvements #6022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use designated example domains as example value - swap "expected" and "actual" values in assertions - add doc / name for each test - add test-cases for remote commands - also test the Spec that's produced, not just the args - merge two test-cases that could be combined Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6022 +/- ##
==========================================
+ Coverage 58.89% 58.92% +0.02%
==========================================
Files 358 358
Lines 29962 29974 +12
==========================================
+ Hits 17647 17662 +15
+ Misses 11334 11332 -2
+ Partials 981 980 -1 🚀 New features to boost your workflow:
|
robmry
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some more changes as follow-ups, but these are some preparations for moving this package to a separate module.
cli/connhelper/ssh: TestParseURL: various improvements
cli/connhelper/ssh: improve GoDoc for ParseURL
cli/connhelper/ssh: use stdlib errors and improve errors
cli/connhelper/commandcon: use stdlib errors
cli/connhelper: use stdlib errors
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)