Add support for multiple platform options in image load and save #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6126 +/- ##
==========================================
+ Coverage 55.02% 55.05% +0.03%
==========================================
Files 361 361
Lines 30152 30161 +9
==========================================
+ Hits 16591 16605 +14
+ Misses 12604 12598 -6
- Partials 957 958 +1 🚀 New features to boost your workflow:
|
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
54b967e to
8993f54
Compare
…/save. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Prior to this change,
docker image loadanddocker image saveaccept only a single platform via the--platformoption.This change adds support for multiple platforms using a comma-separated list passed to
--platform. E.g.:** NOTE **: Depends on the corresponding change in the Moby engine (see moby/moby#50166).
- How I did it
Updated the
--platformoption in theimage loadandimage savecommands to accept an array of platforms, as opposed to a single platform.- How to verify it
Run updated unit tests.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)