cli/command: RegistryAuthenticationPrivilegedFunc: fix hints for login #6135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RegistryAuthenticationPrivilegedFunc has some conditional logic to add additional hints when logging in to the default (Docker Hub) registry. Commit 9f4165c inadvertently passed the wrong variable to PromptUserForCredentials, which caused it to show the additional hints for Docker Hub. Before this patch, hints were printed for the default (docker hub) registry; docker pull icr.io/my-ns/my-image:latest Login prior to pull: Log in with your Docker ID or email address to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com/ to create one. You can log in with your password or a Personal Access Token (PAT). Using a limited-scope PAT grants better security and is required for organizations using SSO. Learn more at https://docs.docker.com/go/access-tokens/ Username: With this patch, those hints are omitted; docker pull icr.io/my-ns/my-image:latest Login prior to pull: Username: Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
I want to look at improving these messages overall, as a the "Login prior to pull:" is a bit awkward, and nothing in the output indicates what registry it's prompting for. |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6135 +/- ##
=======================================
Coverage 55.04% 55.04%
=======================================
Files 361 361
Lines 30152 30152
=======================================
Hits 16596 16596
Misses 12598 12598
Partials 958 958 🚀 New features to boost your workflow:
|
Benehiko
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RegistryAuthenticationPrivilegedFunc has some conditional logic to add additional hints when logging in to the default (Docker Hub) registry. Commit 9f4165c inadvertently passed the wrong variable to PromptUserForCredentials, which caused it to show the additional hints for Docker Hub.
Before this patch, hints were printed for the default (docker hub) registry;
With this patch, those hints are omitted;
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)