8000
adshmh
force-pushed
the
refactor-stack-list-unit-tests
branch
from
September 20, 2018 02:17
refactor stack list command unit tests to table-driven #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
=======================================
Coverage 54.88% 54.88%
=======================================
Files 293 293
Lines 19428 19428
=======================================
Hits 10663 10663
Misses 8089 8089
Partials 676 676 |
cli/command/stack/list_test.go
Outdated
| }, | ||
| for _, tc := range testCases { | ||
| t.Run(tc.doc, func(t *testing.T) { | ||
| services := []swarm.Service{} |
There was a problem hiding this comment.
nit: var services []swarm.Service
There was a problem hiding this comment.
Thank you for the review. I have updated the PR.
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
d24d4ea to
e9dc229
Compare
|
Thank you @adshmh !!! |
lifubang
pushed a commit
to lifubang/cli
that referenced
this pull request
Oct 12, 2018
…ests refactor stack list command unit tests to table-driven Signed-off-by: Lifubang <lifubang@acmcoder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Refactored unit tests of stack list command to table-driven
- How I did it
Modified the unit tests under
cli/command/stack/list_test.go- How to verify it
- Description for the changelog
Refactored stack list unit tests to table-driven
- A picture of a cute animal (not mandatory but encouraged)