8000 update docs with the new features option in daemon.json by AntaresS · Pull Request #1307 · docker/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update docs with the new features option in daemon.json #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2018
Merged

update docs with the new features option in daemon.json #1307

merged 1 commit into from
Aug 24, 2018

Conversation

AntaresS
Copy link
Contributor
@AntaresS AntaresS commented Aug 23, 2018 •
edited
Loading

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Anda Xu anda.xu@docker.com

@AntaresS
update docs with the new features option in daemon.json
3e0b0a6 
Signed-off-by: Anda Xu <anda.xu@docker.com>
@AntaresS
Copy link
Contributor Author

If we are eventually getting rid of --experimental and use only features to control enable/disable features. maybe at some point we should include a list of available features in the reference as well?

@AntaresS
Copy link
Contributor Author
AntaresS commented Aug 23, 2018 •
edited
Loading

ptal @thaJeztah @andrewhsu @brawong @tfoxnc

@codecov-io
Copy link

Codecov Report

Merging #1307 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1307   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         292      292           
  Lines       19267    19267           
=======================================
  Hits        10545    10545           
  Misses       8063     8063           
  Partials      659      659

thaJeztah
thaJeztah approved these changes Aug 23, 2018
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we need to work on documentation for the buildkit features; with that, we should document the buildkit feature in daemon.json as well

Generally, this section of the documentation really needs an overhaul (perhaps investigate generating docs for the configuration file, also see #1058)

vdemeester
vdemeester approved these changes Aug 24, 2018
View reviewed changes
Copy link
Collaborator
@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit 6dbe8ea into docker:master Aug 24, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.09.0 milestone Aug 24, 2018
@thaJeztah thaJeztah mentioned this pull request Aug 27, 2018
Merged
@thaJeztah thaJeztah modified the milestones: 18.09.0, 19.03.0 Oct 2, 2018
@thaJeztah thaJeztah mentioned this pull request Oct 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
kind/docs process/cherry-picked status/3-docs-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AntaresS @codecov-io @vdemeester @thaJeztah @GordonTheTurtle
0