10000 fix: add more details about multiple images filter by ZYecho · Pull Request #1548 · docker/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add more details about multiple images filter #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

ZYecho
Copy link
Contributor
@ZYecho ZYecho commented Dec 5, 2018

Signed-off-by: zhangyue zy675793960@yeah.net

- What I did
As a follow up pr for #38171
add a example for multiple images reference filter.

- How I did it
just change docs
- How to verify it
No need
- Description for the changelog

As a follow up pr for #38171

- A picture of a cute animal (not mandatory but encouraged)
None.

Signed-off-by: zhangyue <zy675793960@yeah.net>
@ZYecho
Copy link
Contributor Author
ZYecho commented Dec 5, 2018

cc @thaJeztah

@codecov-io
Copy link

Codecov Report

Merging #1548 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1548   +/-   ##
=======================================
  Coverage   55.22%   55.22%           
=======================================
  Files         289      289           
  Lines       19389    19389           
=======================================
  Hits        10708    10708           
  Misses       7984     7984           
  Partials      697      697

Copy link
Collaborator
@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor
@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit d8479b4 into docker:master Dec 7, 2018
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Dec 7, 2018
@ZYecho ZYecho deleted the fix-images-filter branch December 8, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0