8000 Add sonarcloud scanning and bump POM versions by david4096 · Pull Request #144 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add sonarcloud scanning and bump POM versions #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 21, 2022
Merged

Add sonarcloud scanning and bump POM versions #144

merged 5 commits into from
Apr 21, 2022

Conversation

david4096
Copy link
Contributor
@david4096 david4096 commented Apr 15, 2022 •
edited
Loading

Adds hooks to sonarcloud for scanning the CLI code.

https://sonarcloud.io/summary/overall?id=dockstore_dockstore-cli

Builds are currently not going due to artifactory. edit: the POMs needed updating

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@david4096 david4096 changed the title Feature/seab 3012/sonar Add sonarcloud scanning and bump POM versions Apr 15, 2022
@codecov
Copy link
codecov bot commented Apr 16, 2022 •
edited
Loading

Codecov Report

Merging #144 (56af4ef) into develop (f180fe1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
+ Coverage    68.11%   68.12%   +0.01%     
===========================================
  Files           47       47              
  Lines         5925     5924       -1     
  Branches       770      770              
===========================================
  Hits          4036     4036              
  Misses        1574     1574              
+ Partials       315      314       -1
Flag Coverage Δ
confidentialtooltests 53.22% <0.00%> (+<0.01%) ⬆️
confidentialworkflowtests 26.13% <0.00%> (+<0.01%) ⬆️
nonconfidentialtests 32.62% <100.00%> (+0.08%) ⬆️
singularitytests 16.84% <0.00%> (+<0.01%) ⬆️
unittests 6.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckstore/client/cli/nested/AbstractEntryClient.java 74.19% <100.00%> (-0.03%) ⬇️
...io/dockstore/client/cli/nested/WesRequestData.java 56.36% <100.00%> (ø)
.../src/main/java/io/dockstore/client/cli/Client.java 47.88% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba63c6...56af4ef. Read the comment docs.

@david4096
Copy link
Contributor Author

Not sure if it's the cause, but LGTM is using maven 3.8.1 and won't complete.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denis-yuen denis-yuen merged commit a54794b into develop Apr 21, 2022
@denis-yuen denis-yuen deleted the feature/seab-3012/sonar branch April 21, 2022 19:16
@david4096
Copy link
Contributor Author

Denis forced merged this because develop LGTM would not build, causing this PR and other subsequent PRs to not pass. This PR fixed develop. See passing build here https://lgtm.com/projects/g/dockstore/dockstore-cli/logs/languages/lang:java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

@chmreid chmreid chmreid approved these changes

@wshands wshands Awaiting requested review from wshands

@Richard-Hansen Richard-Hansen Awaiting requested review from Richard-Hansen

Assignees

@david4096 david4096

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david4096 @coverbeck @denis-yuen @chmreid
0