8000 Remove stale configuration instructions by amarjandu · Pull Request #154 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove stale configuration instructions #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove stale configuration instructions #154

merged 1 commit into from
Jul 20, 2022

Conversation

amarjandu
Copy link
Contributor
@amarjandu amarjandu commented May 18, 2022 •
edited
Loading

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@amarjandu amarjandu force-pushed the issues/amar/update-readme branch 3 times, most recently from 2592de6 to b1e3a0f Compare May 18, 2022 18:00
@codecov
Copy link
codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #154 (1983d21) into develop (6137dec) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    68.12%   68.14%   +0.01%     
===========================================
  Files           47       47              
  Lines         5927     5927              
  Branches       771      771              
===========================================
+ Hits          4038     4039       +1     
  Misses        1574     1574              
+ Partials       315      314       -1
Flag Coverage Δ
confidentialtooltests 53.33% <ø> (ø)
confidentialworkflowtests 26.16% <ø> (ø)
nonconfidentialtests 32.64% <ø> (+0.15%) ⬆️
singularitytests 16.87% <ø> (ø)
unittests 6.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 47.88% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6137dec...1983d21. Read the comment docs.

@amarjandu amarjandu force-pushed the issues/amar/update-readme branch from b1e3a0f to 1983d21 Compare May 18, 2022 21:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amarjandu amarjandu requested review from coverbeck and denis-yuen May 23, 2022 18:45
coverbeck
coverbeck approved these changes May 23, 2022
View reviewed changes
README.md

/dockstore-client/bin/dockstore
Add the directory `dockstore-client/bin` to your PATH:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Optionally add..." -- if I want to test a user's experience with the CLI, I'd want to use the official script, not a developer version.

denis-yuen
denis-yuen approved these changes May 24, 2022
View reviewed changes
Copy link
Member
@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to replace the placeholder text in the PR template (e.g. what issue was this for, its totally ok to just say it was n/a or similar)

@denis-yuen denis-yuen assigned denis-yuen and unassigned amarjandu Jul 20, 2022
@denis-yuen denis-yuen merged commit e51e40c into develop Jul 20, 2022
@denis-yuen denis-yuen deleted the issues/amar/update-readme branch July 20, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@denis-yuen denis-yuen denis-yuen approved these changes

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amarjandu @coverbeck @denis-yuen
0