-
Notifications
You must be signed in to change notification settings - Fork 3
Restore ignored tests #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## develop #176 +/- ##
===========================================
+ Coverage 68.32% 68.62% +0.29%
===========================================
Files 49 49
Lines 6008 6008
Branches 791 791
===========================================
+ Hits 4105 4123 +18
+ Misses 1591 1574 -17
+ Partials 312 311 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
import org.apache.commons.configuration2.INIConfiguration; | ||
import org.apache.commons.io.FileUtils; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
import static io.dockstore.client.cli.ArgumentUtility.Kill; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this re-arrangement is a little odd because it is moving all the static imports from above to below.
that said, the impsort-maven-plugin
configuration does specify that static imports are "after" so this seems better
https://ucsc-cgl.atlassian.net/browse/SEAB-4582
I created a new webservice release,
1.13.0-beta.3
, then restored the tests that were ignored in PR #165.Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install