8000 Restore ignored tests by kathy-t · Pull Request #176 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Restore ignored tests #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

kathy-t
Copy link
Contributor
@kathy-t kathy-t commented Jul 28, 2022

https://ucsc-cgl.atlassian.net/browse/SEAB-4582

I created a new webservice release, 1.13.0-beta.3, then restored the tests that were ignored in PR #165.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@kathy-t kathy-t self-assigned this Jul 28, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
codecov bot commented Jul 29, 2022

Codecov Report

Merging #176 (d2661d5) into develop (725e5bc) will increase coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    68.32%   68.62%   +0.29%     
===========================================
  Files           49       49              
  Lines         6008     6008              
  Branches       791      791              
===========================================
+ Hits          4105     4123      +18     
+ Misses        1591     1574      -17     
+ Partials       312      311       -1     
Flag Coverage Δ
confidentialtooltests 53.31% <ø> (+0.29%) ⬆️
confidentialworkflowtests 28.21% <ø> (ø)
nonconfidentialtests 32.49% <ø> (ø)
singularitytests 16.71% <ø> (ø)
unittests 8.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 48.39% <ø> (+1.23%) ⬆️
.../main/java/io/dockstore/client/cli/YamlClient.java 82.85% <ø> (ø)
...ava/io/dockstore/client/cli/YamlVerifyUtility.java 94.66% <ø> (ø)
...ava/io/dockstore/client/cli/JCommanderUtility.java 93.40% <0.00%> (+1.09%) ⬆️
...ava/io/dockstore/client/cli/nested/DepCommand.java 60.00% <0.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725e5bc...d2661d5. Read the comment docs.

@kathy-t kathy-t marked this pull request as ready for review July 29, 2022 12:30
import org.apache.commons.configuration2.INIConfiguration;
import org.apache.commons.io.FileUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import static io.dockstore.client.cli.ArgumentUtility.Kill;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this re-arrangement is a little odd because it is moving all the static imports from above to below.
that said, the impsort-maven-plugin configuration does specify that static imports are "after" so this seems better

@kathy-t kathy-t merged commit d9a572f into develop Jul 29, 2022
@kathy-t kathy-t deleted the feature/seab-4582/restore-ignored-tests branch July 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0