8000 update bom and generated files by denis-yuen · Pull Request #170 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update bom and generated files #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2022
Merged

update bom and generated files #170

merged 2 commits into from
Jul 14, 2022

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jul 13, 2022 •
edited
Loading

Splitting out bom update from #161 to help narrow down issue with downloading a specific file

Theory is that our old seed DBs actually have bad data in them, verify via

bash scripts/decrypt.sh
grep -R "echo 'hello " .

then compare with https://github.com/DockstoreTestUser2/quayandgithubwdl/blob/master/Dockstore.wdl

  • Check that you pass the basic style checks and unit tests by running mvn clean install

@denis-yuen denis-yuen self-assigned this Jul 13, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link
codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #170 (0ab1752) into develop (927eb54) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    67.81%   67.88%   +0.06%     
===========================================
  Files           47       47              
  Lines         5894     5894              
  Branches       771      771              
===========================================
+ Hits          3997     4001       +4     
+ Misses        1589     1582       -7     
- Partials       308      311       +3
Flag Coverage Δ
confidentialtooltests 52.81% <ø> (+0.03%) ⬆️
confidentialworkflowtests 26.38% <ø> (ø)
nonconfidentialtests 33.10% <ø> (ø)
singularitytests 17.03% <ø> (+0.05%) ⬆️
unittests 6.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/io/dockstore/client/cli/nested/ToolClient.java 72.16% <0.00%> (-0.14%) ⬇️
...ub/collaboratory/cwl/cwlrunner/CWLToolWrapper.java 86.66% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927eb54...0ab1752. Read the comment docs.
8000

@denis-yuen denis-yuen requested review from a team, david4096, kathy-t, svonworl, fhembroff and coverbeck and removed request for a team July 13, 2022 21:00
@denis-yuen denis-yuen marked this pull request as ready for review July 13, 2022 21:00
@denis-yuen denis-yuen merged commit 9e189d6 into develop Jul 14, 2022
@denis-yuen denis-yuen deleted the feature/beta_bom_update branch July 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david4096 david4096 david4096 approved these changes

@kathy-t kathy-t kathy-t approved these changes

@fhembroff fhemb 6502 roff fhembroff approved these changes

@svonworl svonworl svonworl approved these changes

@coverbeck coverbeck Awaiting requested review from coverbeck

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denis-yuen @david4096 @kathy-t @fhembroff @svonworl
0