8000 Feature/grab bag by denis-yuen · Pull Request #173 · dockstore/dockstore-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature/grab bag #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

Feature/grab bag #173

merged 2 commits into from
Jul 21, 2022

Conversation

denis-yuen
Copy link
Member
@denis-yuen denis-yuen commented Jul 20, 2022 •
edited
Loading

@denis-yuen denis-yuen self-assigned this Jul 20, 2022
@denis-yuen denis-yuen mentioned this pull request Jul 20, 2022
Merged
7 tasks
@codecov
Copy link
codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #173 (1d70551) into develop (9e189d6) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #173      +/-   ##
===========================================
- Coverage    67.88%   67.86%   -0.02%     
===========================================
  Files           47       47              
  Lines         5894     5894              
  Branches       771      771              
===========================================
- Hits          4001     4000       -1     
  Misses        1582     1582              
- Partials       311      312       +1
Flag Coverage Δ
confidentialtooltests 52.81% <0.00%> (ø)
confidentialworkflowtests 26.36% <0.00%> (-0.02%) ⬇️
nonconfidentialtests 33.10% <0.00%> (+0.05%) ⬆️
singularitytests 17.03% <0.00%> (ø)
unittests 6.97% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 46.63% <0.00%> (ø)
.../java/io/dockstore/common/WDLFileProvisioning.java 75.71% <0.00%> (ø)
...io/dockstore/client/cli/nested/WorkflowClient.java 74.50% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e189d6...1d70551. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@denis-yuen denis-yuen marked this pull request as ready for review July 20, 2022 21:53
@denis-yuen denis-yuen requested review from a team, david4096, kathy-t, svonworl and coverbeck and removed request for a team July 20, 2022 22:19
@denis-yuen denis-yuen merged commit 77ecd0e into develop Jul 21, 2022
@denis-yuen denis-yuen deleted the feature/grab_bag branch July 21, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@svonworl svonworl Awaiting requested review from svonworl svonworl was automatically assigned from dockstore/dockstore

Assignees

@denis-yuen denis-yuen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-yuen @coverbeck @kathy-t
0